MMSD request

looks like I fixed this.

replace with css? or just add it in manually.

test best standards headers

Student belongs to groups in School A and B, but is only enrolled in School B
User has access only to School A, but has access to group containing student.

So s...

will create new ticket when going to 4.2

devise needs to be 3.4 for rails 4.2 currently 3.3

(from [94bff0c20ca8159860a42fc8338421d041c20362]) [#839 state:resolved] sign_out_and_redirect helper in devise changed, just manually do both https://github.co...

currently 3.3

they're spread out everywhere.
see https://github.com/jehughes/rails3-devise-bootstrap-example/blob/ma...
which uses a PRIVATE_DATA loaded from a yml file in ...

I ended up fixing this by upgrading omniauth-windowslive
[595aa774d712be0ec9f74692606b8ac7fa0485b2]

it doesn't look like anyone is using this now.

(from [2268437b715ac5b96cfdfd216ca41be2a281ecb0]) [#835 state:resolved] fix spell check for checklist builder new answer as css id was not added https://github...

error happens when user doesn't have access to school where student is enrolled
should provide a flash notice instead of throwing an exception.

See this exception on Errbit

NoMethodError: undefined method `id' for nil:NilClass

Summary

URL

https://madison.simspilot.org/students/1044055832?username=B726...

form for adding new answer definition is missing id.

(from [c24ad58a6b0a7fde5aaa42a454d22bb9e50fe80c]) remove references to old change_password url and mailer [#834 state:resolved] https://github.com/vegantech/si...

It's not called anymore, I don't have to support it.

users/passwords/edit

the notifications change_password mailer and view

the old_revovery_url test

It sets the district_id to 0 when searching for the user with the token, this returns invalid password token. It's something similar to https://github.com/plata...

password recovery problem with devise 3.4.0 and 3.4.1 which are the minimum versions for rails 4.2.

devise_secret needs to be created.

3.0 (3.1) for rails 4.
3.4 for rails 4.2

this is done and in production but needs more tests.

(from [6f6875533b1d451cb41bae5ae2f2f399c9cf6ed8]) [#831 state:resolved] Putting the progress monitor description into a table is terrible but worked. https://g...

it should be constrained

(noticed in chrome)

(from [abdb87c72e4247b9cfad73005778cb0926a0a8b8]) disable chrome select popup for now [#830 state:open] https://github.com/vegantech/sims/commit/abdb87c72e4247...

It's supposed to be a helpful reminder, but it doesn't turn off. Insert a help ? after the select instead.

(from [d7dac07c3d71c7de6390ae958620bc3692fc233f]) [#829 state:needs_tests] display no scores image im aggregate graph when no scores are entered https://github...

should state there are no scores.

as image?

https://chart.googleapis.com/chart?cht=tx&chl=no%5C%20scores

error when there are no scores.

See this exception on Errbit

ArgumentError: comparison of NilClass with 0 failed

Summary

URL

https://training.simspilot.org/grouped_progress_entries/6455-3548...

may need to replace them at any time.

(from [d45d23c98d325e83e342a9c214486886556c8ce2]) [#823 state:needs_tests] need to test callback controller but auth domain is implemented https://github.com/v...

(from [64c5e5cf7a2cb7017a35c4d7abb6fa7f50abf952]) [#823] implement google auth2 config, tests need to be fixed and added https://github.com/vegantech/sims/comm...

(from [12bba71cc565e1b25062003e06ef41361d541d1d]) [#828 state:complete] update redcarpet security fix, also remove markdown from checklist title and description...

security vulnerability for redcarpet It doesn't look like it's exploitable for sims but I should upgrade it just in case.

Also the checkklist description and ti...

(from [89bfc439eb63f2c08584ec6e7319685ff44ab78a]) [#827 state:needs_tests] restrict google oauth to current district https://github.com/vegantech/sims/commit/8...

The user is logged out when redirected to the other subdomain. This somewhat mitigated the security issue but was inconvenient. This controller needs tests.

I don't think that they do.

(from [59d11e222c8aef3e2e1890ac6013c06cfdd3b541]) fixed specs and tests to work when google oauth is configured and not for static subdomains [#822 state:resolv...

change help popup on distict settings page.

Can't add districts to openid anymore (rhinelander will have to wait for oauth.)